Support OpenSearch logo theming for light / dark modes #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
AMoo-Miki
force-pushed
the
themed-login-image
branch
from
d11044a to
f6b0dc7
Compare
3 tasks
cwperks
previously approved these changes
Aug 31, 2023
There was a problem hiding this comment.
@AMoo-Miki This change looks good to me. The failing integ tests are unrelated to this change and currently being worked on: opensearch-project/security#3272
|
@AMoo-Miki Can you address the failing unit tests in
|
Signed-off-by: Miki <[email protected]>
AMoo-Miki
force-pushed
the
themed-login-image
branch
from
f6b0dc7 to
75e295a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1568 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 93 93
Lines 2339 2339
Branches 312 312
=======================================
Hits 1548 1548
Misses 722 722
Partials 69 69
|
|
@AMoo-Miki Do you want to get this in for 2.10? The window is closing in pretty fast |
|
@peternied This is blocked by opensearch-project/security#3278 Once the security PR is merged I will re-run the CI |
cwperks
approved these changes
Aug 31, 2023
24 tasks
|
Issue from the security plugin has been merged into main [1], I've retriggered the integration tests. |
stephen-crawford
approved these changes
Sep 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Miki <[email protected]> (cherry picked from commit ecb15d5)
cwperks
pushed a commit
that referenced
this pull request
Sep 5, 2023
Signed-off-by: Miki <[email protected]> (cherry picked from commit ecb15d5) Co-authored-by: Miki <[email protected]>
3 tasks
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change uses the imagery exposed by OSD for the login screen.
Issues Resolved
#1529
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.